beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-450) Modules are shaded to the same path
Date Wed, 27 Jul 2016 21:39:21 GMT


ASF GitHub Bot commented on BEAM-450:

GitHub user dhalperi opened a pull request:

    [BEAM-450] Shade separately per artifact

    Prevents reusing the same path to shaded files across packages.
    R: @lukecwik or @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull beam-450

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
commit b10a427f4ac92d3217dce346a93ef063b4101e47
Author: Dan Halperin <>
Date:   2016-07-26T06:54:34Z

    [BEAM-450] Shade separately per artifact
    Prevents conflicts among shaded files


> Modules are shaded to the same path
> -----------------------------------
>                 Key: BEAM-450
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.1.0-incubating, 0.2.0-incubating
>            Reporter: Daniel Halperin
>            Assignee: Manu Zhang
>              Labels: newbie, starter
> Right now multiple modules are using the same repackaged path. We should be using per-artifact
paths so that they don't conflict.
> One proposal was simply to adopt {{${project.groupId}.${project.artifactId}.repackaged}}
as the shading location. If it works.
> This is a good starter issue.

This message was sent by Atlassian JIRA

View raw message