beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Wegner (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-417) AvroUtils$AvroMetadata exposes mutable syncMarker
Date Fri, 01 Jul 2016 17:09:11 GMT

     [ https://issues.apache.org/jira/browse/BEAM-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Scott Wegner updated BEAM-417:
------------------------------
    Description: 
[FindBugs EI_EXPOSE_REP|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L351]:
May expose internal representation by returning reference to mutable object

Applies to: [AvroUtils$AvroMetadata.getSyncMarker|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/AvroUtils.java#L92].

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.

  was:
[FindBugs FE_FLOATING_POINT_EQUALITY|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L298]:
Test for floating point equality

Applies to: [Mean$CountSum.equals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Mean.java#L165].

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.


> AvroUtils$AvroMetadata exposes mutable syncMarker
> -------------------------------------------------
>
>                 Key: BEAM-417
>                 URL: https://issues.apache.org/jira/browse/BEAM-417
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs EI_EXPOSE_REP|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L351]:
May expose internal representation by returning reference to mutable object
> Applies to: [AvroUtils$AvroMetadata.getSyncMarker|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/util/AvroUtils.java#L92].
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message