beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-405) BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
Date Wed, 06 Jul 2016 12:19:11 GMT

    [ https://issues.apache.org/jira/browse/BEAM-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364232#comment-15364232
] 

ASF GitHub Bot commented on BEAM-405:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/587


> BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
> ------------------------------------------------------------
>
>                 Key: BEAM-405
>                 URL: https://issues.apache.org/jira/browse/BEAM-405
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Lucas Amorim
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>             Fix For: 0.2.0-incubating
>
>
> [FindBugs WMI_WRONG_MAP_ITERATOR|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L124]:
Inefficient use of keySet iterator instead of entrySet iterator
> Applies to: [BigQueryIO$StreamingWriteFn.finishBundle|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BigQueryIO.java#L2080].
This can be made more efficient by using the entrySet iterator.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message