beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-405) BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
Date Sun, 03 Jul 2016 22:51:10 GMT

    [ https://issues.apache.org/jira/browse/BEAM-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360700#comment-15360700
] 

ASF GitHub Bot commented on BEAM-405:
-------------------------------------

GitHub user lucasallan opened a pull request:

    https://github.com/apache/incubator-beam/pull/587

    BEAM-405 - Fixes inefficient use of keySet iterator instead of entrySet iterator

    `BiggQueryIO$StreamingWriteFn.finishBundle`: Fixes inefficient use of keySet iterator
instead of entrySet iterator.
    
    More info: https://issues.apache.org/jira/browse/BEAM-405

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucasallan/incubator-beam beam-405

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/587.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #587
    
----
commit 3a4b2d95a698c776748dd771b816fa1a6f8ad6da
Author: Lucas Amorim <lucasamorim@lucass-macbook-pro.local>
Date:   2016-07-03T22:47:15Z

    [BEAM-405] Fixes inefficient use of keySet iterator instead of entrySet iterator.
    
    BiggQueryIO$StreamingWriteFn.finishBundle: Fixes inefficient use of keySet iterator instead
of entrySet iterator.

----


> BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
> ------------------------------------------------------------
>
>                 Key: BEAM-405
>                 URL: https://issues.apache.org/jira/browse/BEAM-405
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs WMI_WRONG_MAP_ITERATOR|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L124]:
Inefficient use of keySet iterator instead of entrySet iterator
> Applies to: [BigQueryIO$StreamingWriteFn.finishBundle|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BigQueryIO.java#L2080].
This can be made more efficient by using the entrySet iterator.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message