beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-362) Move shared runner functionality out of SDK and into runners/core-java
Date Wed, 20 Jul 2016 04:34:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385303#comment-15385303
] 

ASF GitHub Bot commented on BEAM-362:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/699

    [BEAM-362] Move aggregator-scraping to runners-core

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This moves out aggregators from where they are into various places where they belong.
Notes:
    
     - The runner utility for traversing a pipeline and gathering aggregators is moved out
       to `runners-core`. It could reasonably live in the SDK if it had any other use. It
is
       always easier to re-introduce it that to remove it, so I have removed it for now.
     - The Dataflow runner has a new dependency on `runners-core`.
       This is a private implementation detail dependency. But it cannot be shaded until
       we move packages so everything is under `org.apache.beam.runners.core`.
     - The user-facing aggregator stuff is moved out of the `sdk.runners` namespace to
       live alongside `PipelineResult`, of which is it a sub-part. We might consider all
       of these living in a namespace having to do with interacting with a "job", but that
       is future work. For now this is internally consistent. We have a thought/goal that
       the `sdk.runners` namespace can go away.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam runners-core-aggregators

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #699
    
----
commit 23633b2448f540a0383516d06d9c012cd9f542f4
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-01T21:39:03Z

    Move aggregator scraping util code to runners/core-java

commit 6cbab8c9c82bb67b854e962fb47d7c668a97d3d0
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-01T21:56:20Z

    Move user-facing aggregator classes out of runners namespace

commit 08949dee2fbe60ca097ef23a89ee2c38218815c6
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-20T04:07:22Z

    fixup! deps on runners-core

commit 94d74611193720716e06be0c0fa0ef442ec48a21
Author: Kenneth Knowles <klk@google.com>
Date:   2016-07-20T04:26:11Z

    fixup! references to aggregators

----


> Move shared runner functionality out of SDK and into runners/core-java
> ----------------------------------------------------------------------
>
>                 Key: BEAM-362
>                 URL: https://issues.apache.org/jira/browse/BEAM-362
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message