beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-354) Modify DatastoreIO to use Datastore v1beta3 API
Date Tue, 12 Jul 2016 00:27:11 GMT

    [ https://issues.apache.org/jira/browse/BEAM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371964#comment-15371964
] 

ASF GitHub Bot commented on BEAM-354:
-------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/incubator-beam/pull/635

    BEAM-354: End-to-end tests for V1Beta3 Datastore

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    - Add end-to-end tests for v1beta3 DatastoreIO
    - Common helper functions are under V1Beta3TestUtils, which contains direct reader and
writer for datastore. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam vikasrk/datastoreIOE2ETest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #635
    
----
commit 3f24cf227b6550a5af7c4497108293981a0c529a
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-07-11T18:31:48Z

    datastore e2e tests

commit 4e9d7540349337e1e4b576f5e907d7fab1b1e5d4
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-07-11T23:50:46Z

    Clean up

commit 468124b8887727112b643bd004a82589515b9fae
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-07-12T00:21:31Z

    Checkstyle and some comments

----


> Modify DatastoreIO to use Datastore v1beta3 API
> -----------------------------------------------
>
>                 Key: BEAM-354
>                 URL: https://issues.apache.org/jira/browse/BEAM-354
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>    Affects Versions: 0.2.0-incubating
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>
> Datastore v1beta2 API is getting deprecated in favor of v1beta3. Hence the DatastoreIO
needs to be migrated to use the new version. Also in the process of doing so, this is a good
time to add a level of indirection via a PTranform such that future changes in Datastore API
would not result in changing user/pipeline code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message