beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-328) CoderRegistry does not provide SerializableCoder for `T extends Serializable`
Date Fri, 15 Jul 2016 15:11:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379536#comment-15379536
] 

ASF GitHub Bot commented on BEAM-328:
-------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-beam/pull/663

    [BEAM-328] uses SerializableCoder for `T extends Serializable`

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-beam BEAM-328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #663
    
----
commit f047ce483b4985e017d3a5e7e17e489aa9949fb7
Author: manuzhang <owenzhang1990@gmail.com>
Date:   2016-06-16T04:09:22Z

    [BEAM-328] uses SerializableCoder for `T extends Serializable`

----


> CoderRegistry does not provide SerializableCoder for `T extends Serializable`
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-328
>                 URL: https://issues.apache.org/jira/browse/BEAM-328
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Manu Zhang
>            Priority: Minor
>              Labels: starter
>
> When the type for which a coder is being inferred is a type variable with an upper bound
of {{Serializable}}, it is reasonable for the coder registry to propagate this to the {{SerializableCoder.PROVIDER}},
which should be able to succeed.
> Unfortunately, the particulars of the distinctions made between {{Type}}, {{Class}},
{{TypeVariable}}, {{ParameterizedType}}, etc, go down a code path where this is not the case.
Instead, an error is raised that the type variable has been subject to erasure.
> Originally reported at: https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/298



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message