beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [3/4] incubator-beam git commit: Increase visibility Restrictions in DoFnTester
Date Fri, 15 Jul 2016 00:14:58 GMT
Increase visibility Restrictions in DoFnTester

No in-package representation refers to the fields of DoFnTester
directly.


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/60443524
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/60443524
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/60443524

Branch: refs/heads/master
Commit: 604435249750729b223d90f22300571ff9f4bcfc
Parents: b8cd573
Author: Thomas Groh <tgroh@google.com>
Authored: Thu Jul 14 15:34:36 2016 -0700
Committer: Kenneth Knowles <klk@google.com>
Committed: Thu Jul 14 17:13:11 2016 -0700

----------------------------------------------------------------------
 .../org/apache/beam/sdk/transforms/DoFnTester.java  | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/60443524/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
index f8479de..c38f0ab 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
@@ -639,10 +639,10 @@ public class DoFnTester<InputT, OutputT> {
     FINISHED
   }
 
-  final PipelineOptions options = PipelineOptionsFactory.create();
+  private final PipelineOptions options = PipelineOptionsFactory.create();
 
   /** The original DoFn under test. */
-  final DoFn<InputT, OutputT> origFn;
+  private final DoFn<InputT, OutputT> origFn;
 
   /** The side input values to provide to the DoFn under test. */
   private Map<PCollectionView<?>, Map<BoundedWindow, ?>> sideInputs =
@@ -651,23 +651,23 @@ public class DoFnTester<InputT, OutputT> {
   private Map<String, Object> accumulators;
 
   /** The output tags used by the DoFn under test. */
-  TupleTag<OutputT> mainOutputTag = new TupleTag<>();
+  private TupleTag<OutputT> mainOutputTag = new TupleTag<>();
 
   /** The original DoFn under test, if started. */
   DoFn<InputT, OutputT> fn;
 
   /** The ListOutputManager to examine the outputs. */
-  Map<TupleTag<?>, List<WindowedValue<?>>> outputs;
+  private Map<TupleTag<?>, List<WindowedValue<?>>> outputs;
 
   /** The state of processing of the DoFn under test. */
-  State state;
+  private State state;
 
-  DoFnTester(DoFn<InputT, OutputT> origFn) {
+  private DoFnTester(DoFn<InputT, OutputT> origFn) {
     this.origFn = origFn;
     resetState();
   }
 
-  void resetState() {
+  private void resetState() {
     fn = null;
     outputs = null;
     accumulators = null;
@@ -675,7 +675,7 @@ public class DoFnTester<InputT, OutputT> {
   }
 
   @SuppressWarnings("unchecked")
-  void initializeState() {
+  private void initializeState() {
     fn = (DoFn<InputT, OutputT>)
         SerializableUtils.deserializeFromByteArray(
             SerializableUtils.serializeToByteArray(origFn),


Mime
View raw message