Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: bjchambers <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-521-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #521: [BEAM-37] DoFnReflector: Add inoker interf...
Content-Type: text/plain
Date: Thu, 23 Jun 2016 01:14:04 +0000 (UTC)
archived-at: Thu, 23 Jun 2016 01:14:09 -0000

GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/521

    [BEAM-37] DoFnReflector: Add inoker interface and generate code

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The method to call for a DoFnWithContext requires reflection since the
    shape of the parameters may change. Doing so in each processElement call
    puts this refelection in the hot path.
    
    This PR introduces a DoFnInvoker interface which is bound to a specific
    DoFnWithContext and delegates the three important methods (startBundle,
    processElement, finishBundle).
    
    It uses byte-buddy to generate a simple trampoline implementation of
    the DoFnInvoker class for each type of DoFnWithContext.
    
    This leads to 2-3x better performance in micro-benchmarks of method
    dispatching.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam byte-buddy-dofn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #521
    
----
commit 009be346ecbf4e2db899982f6070e2208e47be10
Author: Ben Chambers <bchambers@google.com>
Date:   2016-06-22T13:47:23Z

    [BEAM-37] DoFnReflector: Add inoker interface and generate code
    
    The method to call for a DoFnWithContext requires reflection since the
    shape of the parameters may change. Doing so in each processElement call
    puts this refelection in the hot path.
    
    This PR introduces a DoFnInvoker interface which is bound to a specific
    DoFnWithContext and delegates the three important methods (startBundle,
    processElement, finishBundle).
    
    It uses byte-buddy to generate a simple trampoline implementation of
    the DoFnInvoker class for each type of DoFnWithContext.
    
    This leads to 2-3x better performance in micro-benchmarks of method
    dispatching.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---