Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: kennknowles <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-471-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #471: [BEAM-336] (roll forward) Base Passert on ...
Content-Type: text/plain
Date: Wed, 15 Jun 2016 18:28:43 +0000 (UTC)
archived-at: Wed, 15 Jun 2016 18:28:48 -0000

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/471

    [BEAM-336] (roll forward) Base Passert on GroupByKey

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam PAssert-roll-forward

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #471
    
----
commit 591db6f0a45b6565bdfe554dd09a2768e68a1eb9
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-15T17:42:59Z

    [Spark] Elide assigning windows when WindowFn is null
    
    Previously, when translating a Window.Bound transform, the case
    where the WindowFn was null was missed, resulting in a
    NullPointerException.

commit eba9ddf2538d37f2c5a8875a37d9f9721ee34ea1
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-08T22:07:52Z

    Roll-forwards: Base PAssert on GBK instead of side inputs
    
    Previously PAssert - hence all RunnableOnService/NeedsRunner
    tests - required side input support. This created a very steep
    on ramp for new runners.
    
    GroupByKey is a bit more fundamental and most backends will be
    able to group by key in the global window very quickly. So switching
    the primitive used to gather all the contents of a PCollection for
    assertions should make it a bit easier to get early feedback during
    runner development.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---