Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: kennknowles <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-457-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #457: Revert GBK-based PAssert
Content-Type: text/plain
Date: Tue, 14 Jun 2016 15:10:56 +0000 (UTC)
archived-at: Tue, 14 Jun 2016 15:11:00 -0000

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/457

    Revert GBK-based PAssert

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This changed neglected the use of counters by the Dataflow runner, which is used to prevent tests for spuriously passing when a `PCollection` is empty (as well as just diagnostic printouts).
    
    Obvious fixes for that revealed probable bugs in the in-process and Spark runner, as well as tests that happen to work with `PAssert` but are actually unsupported.
    
    A proper long-term fix is underway to address all of the above. In the meantime, this commit rolls back the changes to `PAssert`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam PAssert-rollback

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #457
    
----
commit 045b568f6be4b7b010d4fd4cfdd1536db943ce54
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-14T15:05:04Z

    Revert GBK-based PAssert
    
    This changed neglected the use of counters by the Dataflow runner,
    which is used to prevent tests for spuriously passing when
    a PCollection is empty.
    
    Obvious fixes for that revealed probable bugs in the in-process
    and Spark runner, as well as tests that happen to work with
    PAssert but are actually unsupported.
    
    A proper long-term fix is underway to address all of the above.
    In the meantime, this commit rolls back the changes to PAssert.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---