Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: swegner <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-439-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #439: [BEAM-330] Disable exec-maven-plugin clean...
Content-Type: text/plain
Date: Thu,  9 Jun 2016 15:50:59 +0000 (UTC)
archived-at: Thu, 09 Jun 2016 15:51:05 -0000

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/439

    [BEAM-330] Disable exec-maven-plugin cleanupDaemonThreads

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    exec-maven-plugin has a bad interaction with DataflowPipelineRunner
    when waiting on daemon threads. When running example pipelines,
    Maven will emit a warning saying background threads are alive
    after being aborted. This looks to users like an error while there's
    actually no harm to it. Disabling cleanupDaemonThreads suppresses
    this warning.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam exec-cleanupDaemonThreads

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #439
    
----
commit 10154c6f0978cf6f33ae7153e85a02607b6f65ed
Author: Scott Wegner <swegner@google.com>
Date:   2016-06-09T15:46:37Z

    Disable exec-maven-plugin cleanupDaemonThreads
    
    exec-maven-plugin has a bad interaction with DataflowPipelineRunner
    when waiting on daemon threads. When running example pipelines,
    Maven will emit a warning saying background threads are alive
    after being aborted. This looks to users like an error while there's
    actually no harm to it. Disabling cleanupDaemonThreads suppresses
    this warning.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---