Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Thu, 23 Jun 2016 22:21:16 +0000 (UTC)
From: "Luke Cwik (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12982400.1466702030000.15406.1466720476389@Atlassian.JIRA>
In-Reply-To: <JIRA.12982400.1466702030000@Atlassian.JIRA>
References: <JIRA.12982400.1466702030000@Atlassian.JIRA> <JIRA.12982400.1466702030402@arcas>
Subject: [jira] [Updated] (BEAM-372) CoderProperties: Test that the coder
 doesn't consume more bytes than it produces
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 23 Jun 2016 22:21:21 -0000


     [ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Cwik updated BEAM-372:
---------------------------
    Description: 
Add a test to CoderProperties that does the following:

1. Encode a value using the Coder in the nested context
2. Decode the value using the Coder in the nested context
3. Verify that the input stream wasn't requested to consume any extra bytes

(This could possibly just be an enhancement to the existing round-trip encode/decode test)

When this fails it can lead to very difficult to debug situations in a coder wrapped around the problematic coder. This would be an easy test that would clearly fail *for the coder which was problematic*.

  was:
Add a test to CoderProperties that does the following:

1. Encode a value using the Coder
2. Add a byte at the end of the encoded array
3. Decode the value using the Coder
4. Verify the extra byte was not consumed

(This could possibly just be an enhancement to the existing round-trip encode/decode test)

When this fails it can lead to very difficult to debug situations in a coder wrapped around the problematic coder. This would be an easy test that would clearly fail *for the coder which was problematic*.


> CoderProperties: Test that the coder doesn't consume more bytes than it produces
> --------------------------------------------------------------------------------
>
>                 Key: BEAM-372
>                 URL: https://issues.apache.org/jira/browse/BEAM-372
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Davor Bonaci
>            Priority: Minor
>              Labels: beginner, newbie, starter
>
> Add a test to CoderProperties that does the following:
> 1. Encode a value using the Coder in the nested context
> 2. Decode the value using the Coder in the nested context
> 3. Verify that the input stream wasn't requested to consume any extra bytes
> (This could possibly just be an enhancement to the existing round-trip encode/decode test)
> When this fails it can lead to very difficult to debug situations in a coder wrapped around the problematic coder. This would be an easy test that would clearly fail *for the coder which was problematic*.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)