Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EEA12200B3C for ; Wed, 29 Jun 2016 00:43:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EDC33160A6C; Tue, 28 Jun 2016 22:43:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3D555160A56 for ; Wed, 29 Jun 2016 00:43:01 +0200 (CEST) Received: (qmail 93858 invoked by uid 500); 28 Jun 2016 22:43:00 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 93849 invoked by uid 99); 28 Jun 2016 22:43:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 22:43:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 12404CCF30 for ; Tue, 28 Jun 2016 22:43:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.507 X-Spam-Level: X-Spam-Status: No, score=-4.507 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GKOgctVjPUZj for ; Tue, 28 Jun 2016 22:42:58 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 107E75F2F1 for ; Tue, 28 Jun 2016 22:42:57 +0000 (UTC) Received: (qmail 92227 invoked by uid 99); 28 Jun 2016 22:42:57 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 22:42:57 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 187492C1F64 for ; Tue, 28 Jun 2016 22:42:57 +0000 (UTC) Date: Tue, 28 Jun 2016 22:42:57 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-285) Make MinLongFn and MaxLongFn mimic SumLongFn and use BinaryCombineLongFn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Jun 2016 22:43:02 -0000 [ https://issues.apache.org/jira/browse/BEAM-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353820#comment-15353820 ] ASF GitHub Bot commented on BEAM-285: ------------------------------------- GitHub user peihe opened a pull request: https://github.com/apache/incubator-beam/pull/552 [BEAM-285] Avoid boxing and unboxing in transforms Min and Max You can merge this pull request into a Git repository by running: $ git pull https://github.com/peihe/incubator-beam combine-fn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/552.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #552 ---- commit c20e40c2a288bdc5fa7f6370abac20c6492d87c5 Author: Pei He Date: 2016-06-28T22:40:29Z Avoid boxing and unboxing in transforms Min and Max ---- > Make MinLongFn and MaxLongFn mimic SumLongFn and use BinaryCombineLongFn > ------------------------------------------------------------------------ > > Key: BEAM-285 > URL: https://issues.apache.org/jira/browse/BEAM-285 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Mark Shields > Assignee: Pei He > > Ditto for the other 'optimized accumulator' combiner functions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)