Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Wed, 15 Jun 2016 19:08:09 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12964252.1462185887000.9415.1466017689556@Atlassian.JIRA>
In-Reply-To: <JIRA.12964252.1462185887000@Atlassian.JIRA>
References: <JIRA.12964252.1462185887000@Atlassian.JIRA> <JIRA.12964252.1462185887141@arcas>
Subject: [jira] [Commented] (BEAM-243) Remove DirectPipelineRunner and keep
 only the InProcessPipelineRunner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 15 Jun 2016 19:08:15 -0000


    [ https://issues.apache.org/jira/browse/BEAM-243?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D153323=
38#comment-15332338 ]=20

ASF GitHub Bot commented on BEAM-243:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/472

    [BEAM-243] Run NeedsRunner tests in Runner Core on the DirectRunner

    Be sure to do all of the following to help us incorporate your contribu=
tion
    quickly and easily:
   =20
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enabl=
e
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.or=
g/licenses/icla.txt).
   =20
    ---
   =20
    This ensures that all runner tests in runners/core-java are executed in
    the build.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam runners_core_needs_r=
unner_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/472.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #472
   =20
----
commit eeeb8789a3cd9f08554556aa5c01334e1b53d4a4
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-15T19:01:56Z

    Run NeedsRunner tests in Runner Core on the DirectRunner
   =20
    This ensures that all runner tests in runners/core-java are executed in
    the standard maven build.

----


> Remove DirectPipelineRunner and keep only the InProcessPipelineRunner
> ---------------------------------------------------------------------
>
>                 Key: BEAM-243
>                 URL: https://issues.apache.org/jira/browse/BEAM-243
>             Project: Beam
>          Issue Type: Task
>          Components: runner-direct
>            Reporter: Jean-Baptiste Onofr=C3=A9
>            Assignee: Thomas Groh
>
> We have two runners for local JVM/process: the "old" DirectPipelineRunner=
 and the "new" InProcessPipelineRunner.
> They have different feature (for instance the DirectPipelineRunner doesn'=
t support Unbounded PCollection, whereas InProcessPipelineRunner does).
> To avoid confusion, we could remove the "old" DirectPipelineRunner.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)