Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B383D200B0F for ; Fri, 17 Jun 2016 22:07:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B2277160A61; Fri, 17 Jun 2016 20:07:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 08171160A4C for ; Fri, 17 Jun 2016 22:07:09 +0200 (CEST) Received: (qmail 30066 invoked by uid 500); 17 Jun 2016 20:07:09 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 30057 invoked by uid 99); 17 Jun 2016 20:07:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 20:07:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D509AC0E86 for ; Fri, 17 Jun 2016 20:07:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xU69_S7SB9EN for ; Fri, 17 Jun 2016 20:07:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 402E15F1E9 for ; Fri, 17 Jun 2016 20:07:07 +0000 (UTC) Received: (qmail 25991 invoked by uid 99); 17 Jun 2016 20:07:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 20:07:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 672DC2C1F6D for ; Fri, 17 Jun 2016 20:07:05 +0000 (UTC) Date: Fri, 17 Jun 2016 20:07:05 +0000 (UTC) From: "Andrew Psaltis (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-181) Make TextIOTest and AvroIOTest runner-agnostic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Jun 2016 20:07:10 -0000 [ https://issues.apache.org/jira/browse/BEAM-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336824#comment-15336824 ] Andrew Psaltis commented on BEAM-181: ------------------------------------- [~tgroh] I am looking at doing the work for this and trying to understand the desired changes. Are you suggesting that the tempLocation property gets added to the IOChannelUtils and then the read/write tests in TextIO and AvroIO use those properties instead of using "tmpFolder.newFile(.....)" ? > Make TextIOTest and AvroIOTest runner-agnostic > ---------------------------------------------- > > Key: BEAM-181 > URL: https://issues.apache.org/jira/browse/BEAM-181 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Thomas Groh > Priority: Minor > > PipelineOptions contains a tempLocation property, and IOChannelUtils should be capable of handling arbitrary file locations that are used as a tempLocation. > The read and write tests for TextIO and AvroIO can use these properties to be written in a runner-agnostic fashion, and then be marked as RunnableOnService. Doing so allows all runners integrated with RunnableOnService to benefit from the existing tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)