Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Fri, 24 Jun 2016 04:35:16 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12954467.1459294884000.18186.1466742916128@Atlassian.JIRA>
In-Reply-To: <JIRA.12954467.1459294884000@Atlassian.JIRA>
References: <JIRA.12954467.1459294884000@Atlassian.JIRA> <JIRA.12954467.1459294884618@arcas>
Subject: [jira] [Commented] (BEAM-155) Support asserting the contents of
 windows and panes in PAssert
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 24 Jun 2016 04:35:23 -0000


    [ https://issues.apache.org/jira/browse/BEAM-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347682#comment-15347682 ] 

ASF GitHub Bot commented on BEAM-155:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/528

    [BEAM-155] Remove TriggerBuilder backwards-compatibility adapter

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is preparatory work to make it easier to separate trigger syntax from implementation.
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam TriggerBuilder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 244e8e85596c944b23e37e59a717be314c496f74
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-24T04:03:29Z

    Remove TriggerBuilder backwards-compatibility adapter

----


> Support asserting the contents of windows and panes in PAssert
> --------------------------------------------------------------
>
>                 Key: BEAM-155
>                 URL: https://issues.apache.org/jira/browse/BEAM-155
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This consists of reifying the output windows and panes, and running asserts per-window about the contents of panes.
> This includes aggregated matching and final pane matching, e.g.
> PAssert.that(output).byOnTimePane().hasOutputElements(foo, bar);
> // For discarding mode - could have emitted (say) [spam, eggs], [spam], [], [sausage], []
> PAssert.that(output).byFinalPane().hasOutputElements(spam, eggs, sausage, spam);
> // For accumulating mode without late data
> PAssert.that(output).finalPane().containsInAnyOrder(spam, eggs, sausage, spam);
> // For accumulating mode with late data
> PAssert.that(output).finalPane().containsInAnyOrder(foo, bar).mayAlsoContain(baz, rab);
> See also: https://docs.google.com/document/d/1fZUUbG2LxBtqCVabQshldXIhkMcXepsbv2vuuny8Ix4/edit#


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)