beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rangadi <>
Subject [GitHub] incubator-beam pull request #568: [BEAM-395] KafkaIO tests should be marked ...
Date Thu, 30 Jun 2016 18:00:39 GMT
GitHub user rangadi opened a pull request:

    [BEAM-395] KafkaIO tests should be marked 'NeedsRunner'

    KafkaIO Tests are currently marked as 'RunnableOnService', which implies the tests can
run on any beam runner. This is not correct. 
    Though the tests are not runner dependent per se, they depend on mocks for Kafka consumer
and kafka producer. That requires the tests to be local to a JVM. These tests can only run
on single JVM runners like DirectRunner.
    These tests should be marked 'NeedsRunner' for now.
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull test-annotations

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #568


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message