beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aaltay <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #545: Enables more lint rules for Python SDK
Date Tue, 28 Jun 2016 01:22:24 GMT
GitHub user aaltay opened a pull request:

    https://github.com/apache/incubator-beam/pull/545

    Enables more lint rules for Python SDK

    - Fixes some import related warnings and enabled related pylint rules.
    - Replaced (or removed) invalid pylint directives in the g-* form.
    - Use pep8 for blank line related style check. pylint does not check
      for pep8 related to pep8. And pep8 is not configurable for indentations.
      So we need both tools.
    - Fixed existing lint error related to blank lines.
    
    Notes:
    * I excluded 3 files for the below usage:
    
    ```
    T = TypeVariable('T')
    with_input_types(T)
    @with_output_types(List[T])
    class TopCombineFn(core.CombineFn):
    ```
    
    Here pep8 style requires 2 blank lines between first and second lines, even
    though they are logically connected. And there is no option to suppress this
    error locally.
    
    * These tools verify that imports follow the style as defined in here: https://www.python.org/dev/peps/pep-0008/#imports
. This guideline requires the imports to be in standard library / third party / local imports.
This does not necessarily result in an alphabetic import order.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/incubator-beam morelint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #545
    
----
commit 520d2c9f9c5c6a5771879b9b70a226242ef8cfff
Author: Ahmet Altay <altay@google.com>
Date:   2016-06-28T00:59:35Z

    Enables more linting rules.
    
    - Fixes some import related warnings and enabled related pylint rules.
    - Use pep8 for blank line related style check. pylint does not check
      for pep8 related to pep8. And pep8 is not configurable for indentations.
      So we need both tools.
    - Fixed existing lint error related to blank lines.
    
    I excluded 3 files for the below usage:
    
    T = TypeVariable('T')
    with_input_types(T)
    @with_output_types(List[T])
    class TopCombineFn(core.CombineFn):
    
    Here pep8 style require 2 blanks lines between first and second lines, even
    though they are logically connected. And there is no option to suppress this
    error locally.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message