beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #500: Clone the Checkpoint Mark before resuming
Date Mon, 20 Jun 2016 20:52:35 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/500

    Clone the Checkpoint Mark before resuming

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    The documentation for CheckpointMark#finalizeCheckpoint specifies that a
    checkpoint instance that the reader is restarted from will have been
    deserialized from the serialized form of the earlier checkpoint with the
    CheckpointMarkCoder. This brings the direct runner in line with this
    documentation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam unbounded_read_clone

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #500
    
----
commit 7a42205a665ccab08d9378c45b6e47b154c5150b
Author: Thomas Groh <tgroh@google.com>
Date:   2016-06-20T20:51:11Z

    Clone the Checkpoint Mark before resuming
    
    The documentation for CheckpointMark#finalizeCheckpoint specifies that a
    checkpoint instance that the reader is restarted from will have been
    deserialized from the serialized form of the earlier checkpoint with the
    CheckpointMarkCoder. This brings the direct runner in line with this
    documentation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message