beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] incubator-beam pull request #466: [BEAM-243] Remove the DirectPipelineRunner...
Date Wed, 15 Jun 2016 01:24:32 GMT
GitHub user tgroh opened a pull request:

    [BEAM-243] Remove the DirectPipelineRunner from the Core SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull rm_direct_runner

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #466
commit 4da5ebfbf021051288620634ec84cafa9208265c
Author: Thomas Groh <>
Date:   2016-06-14T20:39:59Z

    Use TimestampedValue in DoFnTester
    This removes the duplicate OutputElementWithTimestamp data structure.

commit 3ffc763a231e4b523f220aa6e05aad5c873cc4c7
Author: Thomas Groh <>
Date:   2016-06-14T20:18:41Z

    Add DoFnTester#peekOutputValuesInWindow
    This permits DoFns that interact with windowing to test the windowed,
    rather than overall output.

commit 8d01ae255aa8ec581e923294042c29866cfedfd8
Author: Thomas Groh <>
Date:   2016-06-15T00:51:48Z

    Remove DoFnRunner from GroupAlsoByWindowsProperties
    DoFnRunner is a runner implementation detail, and core SDK code should
    instead use DoFnTester.

commit c88bf988f5ed3c954ae957ea01b6f1b752815418
Author: Thomas Groh <>
Date:   2016-06-15T00:52:49Z

    Remove the DirectPipelineRunner from the Core SDK


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message