beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #452: Fix PAssert with empty collections
Date Mon, 13 Jun 2016 22:13:16 GMT
GitHub user kennknowles opened a pull request:

    Fix PAssert with empty collections

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This branch attempts to fix this in a fairly canonical way, by actually inserting an empty
iterable when the `PCollection` is empty and thus cannot be gathered via GBK.

You can merge this pull request into a Git repository by running:

    $ git pull PAssert-empty

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #452
commit 089d8ae24a65da5a83012076ea50bb191c5b2740
Author: Kenneth Knowles <>
Date:   2016-06-13T21:28:57Z

    Fix PAssert with empty collections


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message