beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #443: Expand set of dependencies to scan for Run...
Date Thu, 09 Jun 2016 21:09:18 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/443

    Expand set of dependencies to scan for RunnableOnService tests

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    I'm afraid we may have gotten off easy on `RunnableOnService` since the SDK was split
into bits and the tests were only pulled in from the core.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam runnable-on-service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #443
    
----
commit 0b953a5b0dd96434edbf4873bf35b4de7e0c2d40
Author: Kenneth Knowles <klk@google.com>
Date:   2016-06-09T21:07:54Z

    Expand set of dependencies to scan for RunnableOnService tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message