beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] incubator-beam pull request #411: [BEAM-22] In the InProcessPipelineRunner, ...
Date Wed, 01 Jun 2016 23:10:34 GMT
GitHub user tgroh opened a pull request:

    [BEAM-22] In the InProcessPipelineRunner, always compare keys by encoding

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Add StructuralKey to use in place of arbitrary objects, and use wherever user
    keys are used to lookup elements.

You can merge this pull request into a Git repository by running:

    $ git pull encoded_object_equality

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #411
commit e2b03b4e670b560ddda659a9b29305e3889e8aee
Author: Thomas Groh <>
Date:   2016-06-01T21:28:18Z

    Add Test for keys that have poor equality

commit 07ad81aca04ab1da419e712be795b14c8f8d6b2d
Author: Thomas Groh <>
Date:   2016-06-01T21:28:49Z

    Use Structural Value keys instead of User Values
    This fixes problems with lookup by basing entirely on structural


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message