beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [11/12] incubator-beam git commit: Directly instantiate SimpleDoFnRunner in its test suite
Date Wed, 22 Jun 2016 02:22:25 GMT
Directly instantiate SimpleDoFnRunner in its test suite

Previously, it went through a static utility class, creating
quasi-circular dependency.


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/efaad322
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/efaad322
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/efaad322

Branch: refs/heads/master
Commit: efaad322f1d3c044b7689764c0eba4f58ded718a
Parents: 3001804
Author: Kenneth Knowles <klk@google.com>
Authored: Tue Jun 21 10:06:36 2016 -0700
Committer: Kenneth Knowles <klk@google.com>
Committed: Tue Jun 21 14:09:49 2016 -0700

----------------------------------------------------------------------
 .../test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/efaad322/sdks/java/core/src/test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java
b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java
index 680422b..fb74fc6 100644
--- a/sdks/java/core/src/test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java
+++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/util/SimpleDoFnRunnerTest.java
@@ -66,7 +66,7 @@ public class SimpleDoFnRunnerTest {
     // Pass in only necessary parameters for the test
     List<TupleTag<?>> sideOutputTags = Arrays.asList();
     StepContext context = mock(StepContext.class);
-    return DoFnRunners.simpleRunner(
+    return new SimpleDoFnRunner<>(
           null, fn, null, null, null, sideOutputTags, context, null, null);
   }
 


Mime
View raw message