beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Wegner (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-409) Inconsistent synchronization in WindowSupplier.windows
Date Thu, 30 Jun 2016 22:41:10 GMT
Scott Wegner created BEAM-409:
---------------------------------

             Summary: Inconsistent synchronization in WindowSupplier.windows
                 Key: BEAM-409
                 URL: https://issues.apache.org/jira/browse/BEAM-409
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Scott Wegner
            Priority: Minor


[FindBugs DM_NEXTINT_VIA_NEXTDOUBLE|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L209]:
Use the nextInt method of Random rather than nextDouble to generate a random integer

Applies to: [ProxyInvocationHandler.hashCode|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ProxyInvocationHandler.java#L96].
This random value is used as a pseudo-unique value for #hashCode(), although the default Object.hasCode()
implementation does the same thing, so this should be unnecessary.

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message