beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Wegner (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-405) BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
Date Thu, 30 Jun 2016 21:14:10 GMT

     [ https://issues.apache.org/jira/browse/BEAM-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Scott Wegner updated BEAM-405:
------------------------------
    Description: 
[FindBugs WMI_WRONG_MAP_ITERATOR|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L124]:
Inefficient use of keySet iterator instead of entrySet iterator

Applies to: [BigQueryIO$StreamingWriteFn.finishBundle|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BigQueryIO.java#L2080].
This can be made more efficient by using the entrySet iterator.

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.

  was:
[FindBugs EI_EXPOSE_REP|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]:
May expose internal representation by returning reference to mutable object

Applies to: [StructuralByteArray|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuralByteArray.java].
Based on usage, it's not entirely clear whether this needs to be fixed. If not, the FindBugs
suppression should be moved out of [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]
and inline as a @SuppressFBWarnings annotation.

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.


> BigQueryIO$StreamingWriteFn uses inefficient keySet iterator
> ------------------------------------------------------------
>
>                 Key: BEAM-405
>                 URL: https://issues.apache.org/jira/browse/BEAM-405
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs WMI_WRONG_MAP_ITERATOR|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L124]:
Inefficient use of keySet iterator instead of entrySet iterator
> Applies to: [BigQueryIO$StreamingWriteFn.finishBundle|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BigQueryIO.java#L2080].
This can be made more efficient by using the entrySet iterator.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message