beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Wegner (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-402) StructuralByteArray exposes mutable internal byte array
Date Thu, 30 Jun 2016 21:10:11 GMT

     [ https://issues.apache.org/jira/browse/BEAM-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Scott Wegner updated BEAM-402:
------------------------------
    Description: 
[FindBugs EI_EXPOSE_REP|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]:
May expose internal representation by returning reference to mutable object

Applies to: [StructuralByteArray|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuralByteArray.java].
Based on usage, it's not entirely clear whether this needs to be fixed. If not, the FindBugs
suppression should be moved out of [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]
and inline as a @SuppressFBWarnings annotation.

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.

  was:
[FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L107]:
Method invokes inefficient new String(String) constructor

Applies to: [StandardCoder.toString|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StandardCoder.java#L104].

This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.


> StructuralByteArray exposes mutable internal byte array
> -------------------------------------------------------
>
>                 Key: BEAM-402
>                 URL: https://issues.apache.org/jira/browse/BEAM-402
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs EI_EXPOSE_REP|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]:
May expose internal representation by returning reference to mutable object
> Applies to: [StructuralByteArray|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StructuralByteArray.java].
Based on usage, it's not entirely clear whether this needs to be fixed. If not, the FindBugs
suppression should be moved out of [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L112]
and inline as a @SuppressFBWarnings annotation.
> This is a good starter bug. When fixing, please remove the corresponding entries from
[findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message