beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-377) BigQueryIO should validate a table or query to read from
Date Sat, 25 Jun 2016 22:03:37 GMT

    [ https://issues.apache.org/jira/browse/BEAM-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349839#comment-15349839
] 

ASF GitHub Bot commented on BEAM-377:
-------------------------------------

GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/535

    [BEAM-377] Validate BigQueryIO.Read is properly configured

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Previously, using withoutValidation would disable all validation,
    leading to a NullPointerException if there wasn't a table or schema
    provided.
    
    The intention of the withoutValidation parameter is to bypass more
    expensive (and possibly incorrect checks, such as the existence of
    the table prior to pipeline execution in cases where earlier stages
    create the table).
    
    This moves the basic usage validation to always happen, while the
    extended validation is still disabled by withoutValidation.
    
    This closes BEAM-377.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam beam-377-bigquery-io

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit bf4f8b693aab539282c72dbc77195cd07d3f24f8
Author: Ben Chambers <bchambers@google.com>
Date:   2016-06-25T21:11:17Z

    [BEAM-377] Validate BigQueryIO.Read is properly configured
    
    Previously, using withoutValidation would disable all validation,
    leading to a NullPointerException if there wasn't a table or schema
    provided.
    
    The intention of the withoutValidation parameter is to bypass more
    expensive (and possibly incorrect checks, such as the existence of
    the table prior to pipeline execution in cases where earlier stages
    create the table).
    
    This moves the basic usage validation to always happen, while the
    extended validation is still disabled by withoutValidation.

----


> BigQueryIO should validate a table or query to read from
> --------------------------------------------------------
>
>                 Key: BEAM-377
>                 URL: https://issues.apache.org/jira/browse/BEAM-377
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message