beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-354) Modify DatastoreIO to use Datastore v1beta3 API
Date Mon, 20 Jun 2016 18:41:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340149#comment-15340149
] 

ASF GitHub Bot commented on BEAM-354:
-------------------------------------

GitHub user vikkyrk opened a pull request:

    https://github.com/apache/incubator-beam/pull/499

    [BEAM-354]: Modify DatastoreIO to use the v1beta3 API

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    - Use v1beta3 datastore API and remove all v1beta2 dependencies
    - Modify tests to pass. 
      

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vikkyrk/incubator-beam vikasrk/datastoreIO-v1beta3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #499
    
----
commit af35d9829581a450245153dbfb7db23f9ed9fff0
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-06-16T20:57:43Z

    DatastoreIO: Update datastore API to v1beta3

commit 88b34f746e6332aec69cf1c60212971aae0f9fc0
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-06-20T17:38:43Z

    DatastoreIO: Update comments

commit 834b87394f5834f7c6475032cafaed89be977ecb
Author: Vikas Kedigehalli <vikasrk@google.com>
Date:   2016-06-20T18:39:14Z

    DatastoreIO: remove unused imports

----


> Modify DatastoreIO to use Datastore v1beta3 API
> -----------------------------------------------
>
>                 Key: BEAM-354
>                 URL: https://issues.apache.org/jira/browse/BEAM-354
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>            Reporter: Vikas Kedigehalli
>            Assignee: Vikas Kedigehalli
>
> Datastore v1beta2 API is getting deprecated in favor of v1beta3. Hence the DatastoreIO
needs to be migrated to use the new version. Also in the process of doing so, this is a good
time to add a level of indirection via a PTranform such that future changes in Datastore API
would not result in changing user/pipeline code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message