beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-343) DisplayData error in AfterWatermark
Date Wed, 15 Jun 2016 16:56:09 GMT

    [ https://issues.apache.org/jira/browse/BEAM-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332083#comment-15332083
] 

ASF GitHub Bot commented on BEAM-343:
-------------------------------------

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/469

    [BEAM-343] Fix NullPointerException in AfterWatermark display data

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Window transforms register display data for the associated trigger
    function by calling its .toString() method. The AfterWatermark
    trigger .toString() method was not properly handling cases where
    there is no late firings registered.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam afterwatermark-displaydata

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----
commit 28c47c8e48e78b7bc23ae96661a1ee25fd3b4599
Author: Scott Wegner <swegner@google.com>
Date:   2016-06-15T16:51:59Z

    Fix NullPointerException in AfterWatermark display data
    
    Window transforms register display data for the associated trigger
    function by calling its .toString() method. The AfterWatermark
    trigger .toString() method was not properly handling cases where
    there is no late firings registered.

----


> DisplayData error in AfterWatermark
> -----------------------------------
>
>                 Key: BEAM-343
>                 URL: https://issues.apache.org/jira/browse/BEAM-343
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 0.1.0-incubating, 0.2.0-incubating
>            Reporter: Daniel Mills
>            Assignee: Scott Wegner
>
> If AfterWatermark is used with early firings but no late firings, toString (used by DisplayData)
crashes because there is no trigger at LATE_INDEX.
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterWatermark.java#L239



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message