beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-342) Change Filter#greaterThan, etc. to actually use Filter
Date Thu, 16 Jun 2016 18:23:05 GMT

    [ https://issues.apache.org/jira/browse/BEAM-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334381#comment-15334381
] 

ASF GitHub Bot commented on BEAM-342:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/468


> Change Filter#greaterThan, etc. to actually use Filter
> ------------------------------------------------------
>
>                 Key: BEAM-342
>                 URL: https://issues.apache.org/jira/browse/BEAM-342
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Manu Zhang
>            Priority: Minor
>              Labels: starter
>
> This is a good starter task.
> Right now, [{{Filter#greaterThan}}|https://github.com/apache/incubator-beam/blob/315b3c8e333e5f42730c19e89f856d778ce93cab/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java#L134]
constructs a new DoFn rather than using {{Filter#byPredicate}}. We should fix this to make
it consistent and simpler.
> We can also remove deprecated functions in that file, and if possible redundant display
data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message