beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-330) Maven exec warning message on Dataflow WordCount Example
Date Thu, 09 Jun 2016 15:51:20 GMT

    [ https://issues.apache.org/jira/browse/BEAM-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322745#comment-15322745
] 

ASF GitHub Bot commented on BEAM-330:
-------------------------------------

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/439

    [BEAM-330] Disable exec-maven-plugin cleanupDaemonThreads

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    exec-maven-plugin has a bad interaction with DataflowPipelineRunner
    when waiting on daemon threads. When running example pipelines,
    Maven will emit a warning saying background threads are alive
    after being aborted. This looks to users like an error while there's
    actually no harm to it. Disabling cleanupDaemonThreads suppresses
    this warning.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam exec-cleanupDaemonThreads

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #439
    
----
commit 10154c6f0978cf6f33ae7153e85a02607b6f65ed
Author: Scott Wegner <swegner@google.com>
Date:   2016-06-09T15:46:37Z

    Disable exec-maven-plugin cleanupDaemonThreads
    
    exec-maven-plugin has a bad interaction with DataflowPipelineRunner
    when waiting on daemon threads. When running example pipelines,
    Maven will emit a warning saying background threads are alive
    after being aborted. This looks to users like an error while there's
    actually no harm to it. Disabling cleanupDaemonThreads suppresses
    this warning.

----


> Maven exec warning message on Dataflow WordCount Example
> --------------------------------------------------------
>
>                 Key: BEAM-330
>                 URL: https://issues.apache.org/jira/browse/BEAM-330
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-java
>            Reporter: Scott Wegner
>            Assignee: Scott Wegner
>            Priority: Minor
>
> When running the WordCount example with DataflowPipelineRunner, sometimes the Maven process
will emit a warning when trying to tear down the process:
> {quote}{noformat}
> [DEBUG] interrupting thread Thread[pool-1-thread-1,5,org.apache.beam.examples.WordCount]
> [DEBUG] joining on thread Thread[pool-1-thread-1,5,org.apache.beam.examples.WordCount]
> [WARNING] thread Thread[pool-1-thread-1,5,org.apache.beam.examples.WordCount] was interrupted
but is still alive after waiting at least 14999msecs
> [WARNING] thread Thread[pool-1-thread-1,5,org.apache.beam.examples.WordCount] will linger
despite being asked to die via interruption
> [WARNING] NOTE: 1 thread(s) did not finish despite being asked to  via interruption.
This is not a problem with exec:java, it is a problem with the running code. Although not
serious, it should be remedied.
> [WARNING] Couldn't destroy threadgroup org.codehaus.mojo.exec.ExecJavaMojo$IsolatedThreadGroup[name=org.apache.beam.examples.WordCount,maxpri=10]
> {noformat}{quote}
> This appears to be some bad interaction between exec-maven-plugin and DataflowPipelineRunner,
possibly due to exec-maven-plugin's use of Guice and our shading of it.
> The problem doesn't always reproduce, except when executing multiple Maven targets, such
as "mvn install exec:java \[...\]"
> Disabling exec:java's cleanupDaemonThreads indeed suppresses the issue.  I recommend
we add this configuration to the root pom.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message