Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 10BA42007D0 for ; Tue, 10 May 2016 20:32:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0EAF016098A; Tue, 10 May 2016 18:32:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54FD9160877 for ; Tue, 10 May 2016 20:32:17 +0200 (CEST) Received: (qmail 51955 invoked by uid 500); 10 May 2016 18:32:16 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 51946 invoked by uid 99); 10 May 2016 18:32:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 18:32:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2DC09C0187 for ; Tue, 10 May 2016 18:32:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.73 X-Spam-Level: X-Spam-Status: No, score=-1.73 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, TVD_SUBJ_WIPE_DEBT=2.291] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vvmgg2ABN0bU for ; Tue, 10 May 2016 18:32:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 0F8175F36D for ; Tue, 10 May 2016 18:32:13 +0000 (UTC) Received: (qmail 50697 invoked by uid 99); 10 May 2016 18:32:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 18:32:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D5A3D2C0451 for ; Tue, 10 May 2016 18:32:12 +0000 (UTC) Date: Tue, 10 May 2016 18:32:12 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (BEAM-191) Remove WindowedValue.valueInEmptyWindows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 May 2016 18:32:18 -0000 [ https://issues.apache.org/jira/browse/BEAM-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles reassigned BEAM-191: ------------------------------------ Assignee: Kenneth Knowles > Remove WindowedValue.valueInEmptyWindows > ---------------------------------------- > > Key: BEAM-191 > URL: https://issues.apache.org/jira/browse/BEAM-191 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Priority: Minor > Labels: windowing > > Even though it is acceptable to create a WindowedValue carrying no windows when it is a fully reified WindowedValue, it doesn't really make sense: When it becomes an element in a PCollection that a value must exist within some window. > This has led to some confusion so we should remove the API. It seems there are just 11 files that reference WindowedValue.valueInEmptyWindows [1] that mostly look like they'd be fine with the global window. > [1] https://github.com/apache/incubator-beam/search?p=1&q=valueInEmptyWindows&utf8=%E2%9C%93 -- This message was sent by Atlassian JIRA (v6.3.4#6332)