Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Wed, 11 May 2016 16:39:15 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.12950918.1458150638000.166959.1462984755404@Atlassian.JIRA>
In-Reply-To: <JIRA.12950918.1458150638000@Atlassian.JIRA>
References: <JIRA.12950918.1458150638000@Atlassian.JIRA> <JIRA.12950918.1458150638927@arcas>
Subject: [jira] [Commented] (BEAM-117) Implement the API for Static Display
 Metadata
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 11 May 2016 16:39:26 -0000


    [ https://issues.apache.org/jira/browse/BEAM-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280395#comment-15280395 ] 

ASF GitHub Bot commented on BEAM-117:
-------------------------------------

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/325

    [BEAM-117] Validate display data registration in Dataflow Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    The DataflowRunner (like other runners) transforms pipelines during construction and sends only primitive transforms to its service. This PR validates that primitive transforms are correctly registering display data for IO transforms.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam displaydata-dataflow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit c03af9e254497c9af9674b2b9517fe0b1db5381b
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T20:31:39Z

    Add overload for DisplayDataMatchers.hasDisplayItem

commit 48b30e8e133a1949693fa854883471ca623e05a4
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T20:50:01Z

    Correct DisplayDataEvaluator behavior for primitives
    
    Previously DisplayDataEvaluator would assume the input PTransform
    was a composite and if so collect DisplayData for inner primitives.
    However it incorrectly discarding DisplayData when the input itself
    is a primitive. This fixes the tracking logic.

commit be44a9bdd81e054e7e235eae613b8c35b9f9738b
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T20:52:49Z

    Implement TransformTreeNode.toString
    
    Previously TransformTreeNode took the default Object#toString
    implementation, which displays the class name and ID number. This
    change instead uses the fullName property, which is the path of
    inner tranform within the graph. This is very useful for stepping
    through graph transformation logic in a debugger. The toString
    implelementation is not necessary for correctness.

commit b5b7c9baeebb27cdc5f7ed5074f1d764299837b2
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T20:55:07Z

    Add pinning test to verify BigQueryIO display data

commit de888f9b353d6addc86662cd010089dc869a9854
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T21:06:24Z

    Add pinning test for DatastoreIO display data

commit dd26b46867755612aff4a74b7222ea7435a73966
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T21:09:34Z

    Add pinning test for TextIO display data

commit 2a3229bcafbdbdcd613fd16b511041f0e01c5700
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T21:17:50Z

    Add pinning test for AvroIO display data

commit df8b28de636454d4b580898fa8870c0929a3cf8d
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-09T21:23:38Z

    Add pinning test for PubsubIO display data

----


> Implement the API for Static Display Metadata
> ---------------------------------------------
>
>                 Key: BEAM-117
>                 URL: https://issues.apache.org/jira/browse/BEAM-117
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Ben Chambers
>            Assignee: Scott Wegner
>
> As described in the following doc, we would like the SDK to allow associating display metadata with PTransforms.
> https://docs.google.com/document/d/11enEB9JwVp6vO0uOYYTMYTGkr3TdNfELwWqoiUg5ZxM/edit?usp=sharing


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)