Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6C508200AC8 for ; Tue, 24 May 2016 00:43:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6AEC7160A0E; Mon, 23 May 2016 22:43:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B4FE4160A24 for ; Tue, 24 May 2016 00:43:16 +0200 (CEST) Received: (qmail 33695 invoked by uid 500); 23 May 2016 22:43:16 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 33686 invoked by uid 99); 23 May 2016 22:43:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2016 22:43:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 94C4D1A5B67 for ; Mon, 23 May 2016 22:43:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id SKqU-zw4Xeqv for ; Mon, 23 May 2016 22:43:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id D1ED35F343 for ; Mon, 23 May 2016 22:43:13 +0000 (UTC) Received: (qmail 33580 invoked by uid 99); 23 May 2016 22:43:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 May 2016 22:43:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CECE62C033A for ; Mon, 23 May 2016 22:43:12 +0000 (UTC) Date: Mon, 23 May 2016 22:43:12 +0000 (UTC) From: "Davor Bonaci (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-88) DataflowPipelineOptions.tempLocation doesn't really default to stagingLocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 23 May 2016 22:43:17 -0000 [ https://issues.apache.org/jira/browse/BEAM-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297271#comment-15297271 ] Davor Bonaci commented on BEAM-88: ---------------------------------- [~ilganeli], awesome! We look forward to your contributions. [~peihe], is this still up to date? > DataflowPipelineOptions.tempLocation doesn't really default to stagingLocation > ------------------------------------------------------------------------------ > > Key: BEAM-88 > URL: https://issues.apache.org/jira/browse/BEAM-88 > Project: Beam > Issue Type: Bug > Components: runner-dataflow > Reporter: Eugene Kirpichov > Priority: Trivial > > The documentation of DataflowPipelineOptions.tempLocation says: ..."defaults to using stagingLocation."... > However calling .getTempLocation() when only --stagingLocation is specified on the command line gives null. > The "defaulting" is really done in DataflowPipelineRunner.fromOptions(): > {code} > if (Strings.isNullOrEmpty(dataflowOptions.getTempLocation())) { > dataflowOptions.setTempLocation(dataflowOptions.getStagingLocation()); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)