Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6809B2009F3 for ; Fri, 20 May 2016 22:05:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 66C59160A25; Fri, 20 May 2016 20:05:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B0FB71607AA for ; Fri, 20 May 2016 22:05:17 +0200 (CEST) Received: (qmail 82918 invoked by uid 500); 20 May 2016 20:05:16 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 82909 invoked by uid 99); 20 May 2016 20:05:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2016 20:05:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5850BC0D82 for ; Fri, 20 May 2016 20:05:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id JYNx74s6RbCh for ; Fri, 20 May 2016 20:05:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 199FC5FAD2 for ; Fri, 20 May 2016 20:05:14 +0000 (UTC) Received: (qmail 82233 invoked by uid 99); 20 May 2016 20:05:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2016 20:05:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DF80D2C1F5D for ; Fri, 20 May 2016 20:05:12 +0000 (UTC) Date: Fri, 20 May 2016 20:05:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-53) PubSubIO: reimplement in Java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 May 2016 20:05:18 -0000 [ https://issues.apache.org/jira/browse/BEAM-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294084#comment-15294084 ] ASF GitHub Bot commented on BEAM-53: ------------------------------------ GitHub user dhalperi opened a pull request: https://github.com/apache/incubator-beam/pull/367 [BEAM-53] PubSub: build fixups * Always RunWith on a unit test * Mockito bugfix for Java 9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhalperi/incubator-beam build-fixups Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 ---- commit 30c3c3b5f6c95c9d9a6febde391558023ccf73bd Author: Dan Halperin Date: 2016-05-20T20:04:12Z PubSub: build fixups * Always RunWith on a unit test * Mockito bugfix for Java 9 ---- > PubSubIO: reimplement in Java > ----------------------------- > > Key: BEAM-53 > URL: https://issues.apache.org/jira/browse/BEAM-53 > Project: Beam > Issue Type: New Feature > Components: runner-core > Reporter: Daniel Halperin > Assignee: Mark Shields > > PubSubIO is currently only partially implemented in Java: the DirectPipelineRunner uses a non-scalable API in a single-threaded manner. > In contrast, the DataflowPipelineRunner uses an entirely different code path implemented in the Google Cloud Dataflow service. > We need to reimplement PubSubIO in Java in order to support other runners in a scalable way. > Additionally, we can take this opportunity to add new features: > * getting timestamp from an arbitrary lambda in arbitrary formats rather than from a message attribute in only 2 formats. > * exposing metadata and attributes in the elements produced by PubSubIO.Read > * setting metadata and attributes in the messages written by PubSubIO.Write -- This message was sent by Atlassian JIRA (v6.3.4#6332)