beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Return from awaitCompletion if Alread...
Date Mon, 30 May 2016 18:04:33 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/399

    Return from awaitCompletion if Already Done

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This ensures that a call to ExecutorService#awaitCompletion returns immediately
    if there are no visible updates and the executor has completed. If the executor is
    in this state, no additional visible updates will be published and the call will hang.
    
    This sequence generally will not happen, as calls via InProcessPipelineResult
    return if the state is already terminal, but this ensures that parallel calls to
    awaitCompletion do not hang one calling thread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #399
    
----
commit bae8146b9c061618d0d4e41c719a150b93201bb5
Author: Thomas Groh <tgroh@users.noreply.github.com>
Date:   2016-05-30T18:04:15Z

    Return from awaitCompletion if Already Done
    
    This ensures that a call to ExecutorService#awaitCompletion returns immediately
    if there are no visible updates and the executor has completed. If the executor is
    in this state, no additional visible updates will be published and the call will hang.
    
    This sequence generally will not happen, as calls via InProcessPipelineResult
    return if the state is already terminal, but this ensures that parallel calls to
    awaitCompletion do not hang one calling thread.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message