beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mshields822 <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-306] Serialize/Deserialize chec...
Date Wed, 25 May 2016 16:16:28 GMT
GitHub user mshields822 opened a pull request:

    https://github.com/apache/incubator-beam/pull/388

    [BEAM-306] Serialize/Deserialize checkpoints

    R: @dhalperi @tgroh 
    
    The PubsubUnboundendSource implementation has an assertion to confirm the checkpoint from
which a fresh reader is instantiated has come via deserialization from an earlier finalized
checkpoint. The in-process runner was reusing the checkpoint object directly, so the assertion
failed. This adds the serialize/deserialize to the in-process runner, which I believe is the
best solution since other UnboundedSources may be caught by the same issue. It also forces
the user to exercise their checkpoint coder.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mshields822/incubator-beam pubsub-inproc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
    
----
commit 4f4b526495a887bbc1c9b782850e9785a86bddc9
Author: Mark Shields <markshields@google.com>
Date:   2016-05-25T16:13:07Z

    Serialize/Deserialize checkpoints

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message