beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Relocate Immutability Enforcement tes...
Date Wed, 25 May 2016 01:07:19 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/387

    Relocate Immutability Enforcement tests

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    These tests exercise a runner behavior rather than an inherent ParDo behavior; move
    to the runner that applies this enforcement.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam relocate_immutability_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit 8875f5e91fa5b0e42215020d15a5d016dead7886
Author: Thomas Groh <tgroh@google.com>
Date:   2016-05-25T01:05:16Z

    Stop wrapping IllegalMutationExceptions
    
    This surfaces failures due to model invariant violations directly,
    rather than going through a PipelineExecutionException.

commit db32e18d1258c3337063abd4a14da01b7a718ae8
Author: Thomas Groh <tgroh@google.com>
Date:   2016-05-25T00:53:05Z

    Relocate Immutability Enforcement Runner Tests
    
    Strict Enforcement of Immutability is not a model property, but a runner
    property. Move to a runner that applies this enforcement.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message