beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Remove TestIO, Use CountingInput in C...
Date Fri, 20 May 2016 20:18:27 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/368

    Remove TestIO, Use CountingInput in CustomSourcesTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    CountingInput is implemented on top of CountingSource, which is
    implemented via the Source API. This removes additional implementations
    of sources-for-testing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam rm_testio

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #368
    
----
commit 86587b711be2a2d7a1d1634c834b35740719c195
Author: Thomas Groh <tgroh@google.com>
Date:   2016-05-20T20:16:33Z

    Use CountingInput in CustomSourcesTest
    
    CountingInput is implemented on top of CountingSource, which is
    implemented via the Source API. This removes additional implementations
    of sources-for-testing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message