beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Add CrashingRunner for use in TestPip...
Date Thu, 19 May 2016 00:51:54 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/349

    Add CrashingRunner for use in TestPipeline

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    CrashingRunner is a PipelineRunner that crashes on calls to run() with
    an IllegalArgumentException. As a runner is currently required to
    construct a Pipeline object, this allows removal of all Pipeline Runners
    from the core SDK while retaining tests that depend only on the graph
    construction behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam crashing_runner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit f3d43f0fa6e20249d0017e6edbc94e5b61055251
Author: Thomas Groh <tgroh@google.com>
Date:   2016-05-18T20:37:13Z

    Add CrashingRunner for use in TestPipeline
    
    CrashingRunner is a PipelineRunner that crashes on calls to run() with
    an IllegalArgumentException. As a runner is currently required to
    construct a Pipeline object, this allows removal of all Pipeline Runners
    from the core SDK while retaining tests that depend only on the graph
    construction behavior.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message