beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swegner <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: [BEAM-117] Runners should be resilien...
Date Tue, 10 May 2016 18:25:28 GMT
GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam/pull/315

    [BEAM-117] Runners should be resilient to DisplayData failure

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Display data is collected from PTransforms at Pipeline construction
    time. Collecting display data runs user code from provided transforms
    and fn's. These components should be designed not to throw during
    pipeline construction, however we also shouldn't fail a pipeline
    if this code does fail.
    
    This PR adds resiliency to the DataflowPipelineTranslator, where
    we collect display data for the Dataflow runner, and also a
    RunnableOnService test to verify that all runners are resilient to
    display data failures. Other runners are not yet using display data,
    but will get this validation for free when they do.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam displaydata-safe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #315
    
----
commit d6c5025937cbd0016d0a83d08e53902ae4d4519b
Author: Scott Wegner <swegner@google.com>
Date:   2016-05-10T18:19:14Z

    Runners should be resilient to DisplayData failure
    
    Display data is collected from PTransforms at Pipeline construction
    time. Collecting display data runs user code from provided transforms
    and fn's. These components should be designed not to throw during
    pipeline construction, however we also shouldn't fail a pipeline
    if this code does fail.
    
    This PR adds resiliency to the DataflowPipelineTranslator, where
    we collect display data for the Dataflow runner, and also a
    RunnableOnService test to verify that all runners are resilient to
    display data failures. Other runners are not yet using display data,
    but will get this validation for free when they do.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message