beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request: Suppress spurious SDK builds
Date Wed, 04 May 2016 21:59:55 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/288

    Suppress spurious SDK builds

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is a low tech solution that mostly keeps the status quo but seems to eliminate the
extra builds. The current method won't work if the SDK is ever shaded, since it depends on
absolute paths in magic strings, but this PR doesn't try to solve that problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam exclude-package-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #288
    
----
commit c6726c7a2bffee90b8d8a541d466ac7c90110a0b
Author: Kenneth Knowles <klk@google.com>
Date:   2016-05-04T04:30:51Z

    Exclude package-info.java from compiled sources list
    
    This is a workaround for [MCOMPILER-205], which causes
    maven-compiler-plugin to always detect stale sources due to sources
    that do not create a class file, such as package-info.java.
    
    An alternative workaround is to add dummy annotations to all
    package-info.java files, which will induce package-info.class
    files.
    
    [MCOMPILER-205](https://issues.apache.org/jira/browse/MCOMPILER-205)

commit 75ae620c52a691db57e9ea48befc9eb91741ef80
Author: Kenneth Knowles <klk@google.com>
Date:   2016-05-04T21:55:17Z

    Ignore generated sdk.properties from sources list
    
    This file is generated exclusively through maven filtering, but
    causes spurious rebuilds.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message