beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <>
Subject [jira] [Commented] (BEAM-306) Make java-only PubsubIO work in InProcessRunner
Date Wed, 25 May 2016 18:21:12 GMT


Kenneth Knowles commented on BEAM-306:

I think there's a confusing ambiguity at [this line in UnboundedSource|]
in the spec for getting a checkpoint.

"The returned object should not be modified."

By whom? We can't say that it applies to everyone, since the interface for the checkpoint
includes a finalization method. I think the most reasonable interpretation (and anyhow the
one that seems obvious anyhow) is that once the object is returned, the source no longer owns
it; the context owns it. So the source should not hang on to it, or at least should not do
anything observable with it. But [] and [] might have
a different idea.

> Make java-only PubsubIO work in InProcessRunner 
> ------------------------------------------------
>                 Key: BEAM-306
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields

This message was sent by Atlassian JIRA

View raw message