beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-306) Make java-only PubsubIO work in InProcessRunner
Date Wed, 25 May 2016 16:17:13 GMT


ASF GitHub Bot commented on BEAM-306:

GitHub user mshields822 opened a pull request:

    [BEAM-306] Serialize/Deserialize checkpoints

    R: @dhalperi @tgroh 
    The PubsubUnboundendSource implementation has an assertion to confirm the checkpoint from
which a fresh reader is instantiated has come via deserialization from an earlier finalized
checkpoint. The in-process runner was reusing the checkpoint object directly, so the assertion
failed. This adds the serialize/deserialize to the in-process runner, which I believe is the
best solution since other UnboundedSources may be caught by the same issue. It also forces
the user to exercise their checkpoint coder.

You can merge this pull request into a Git repository by running:

    $ git pull pubsub-inproc

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
commit 4f4b526495a887bbc1c9b782850e9785a86bddc9
Author: Mark Shields <>
Date:   2016-05-25T16:13:07Z

    Serialize/Deserialize checkpoints


> Make java-only PubsubIO work in InProcessRunner 
> ------------------------------------------------
>                 Key: BEAM-306
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields

This message was sent by Atlassian JIRA

View raw message