beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-299) MergingActiveWindowSet does not preserve invariants across persist/restore
Date Tue, 24 May 2016 00:11:12 GMT

    [ https://issues.apache.org/jira/browse/BEAM-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297393#comment-15297393
] 

ASF GitHub Bot commented on BEAM-299:
-------------------------------------

GitHub user mshields822 opened a pull request:

    https://github.com/apache/incubator-beam/pull/380

    [BEAM-299] Fix invariant failure in MergingActiveWindowSet

    The 'windowToActiveWindow' map in MergingActiveWindowSet had a confused invariant. It
was partially tracking the window-to-merged-window map needed while processing a single bundle
in ReduceFnRunner. But it was also tracking which 'state address windows' correspond to which
active windows. The invariants were written for the second use, which was no longer correct.
    
    This  PR factors out the window-to-merged-window map into the  ReduceFnRunner and simplifies
what's left.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mshields822/incubator-beam beam-299

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #380
    
----
commit 6fc07c9715378920b886226168faf4129354b407
Author: Mark Shields <markshields@google.com>
Date:   2016-05-24T00:06:48Z

    Factor toBeMerged->mergeResult map out of MergingActiveWindowSet, clean it up, and
improve unit tests

----


> MergingActiveWindowSet does not preserve invariants across persist/restore
> --------------------------------------------------------------------------
>
>                 Key: BEAM-299
>                 URL: https://issues.apache.org/jira/browse/BEAM-299
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Mark Shields
>            Assignee: Mark Shields
>
> Can cause a check fail on --update with Sessions windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message