beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-286) Reorganize flink runner directories
Date Wed, 18 May 2016 16:48:12 GMT

    [ https://issues.apache.org/jira/browse/BEAM-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289295#comment-15289295
] 

ASF GitHub Bot commented on BEAM-286:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/348

    [BEAM-286] Reorganize flink runner module to follow other runners str…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Reorganize flink runner module to follow other runners structure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-286-REORG-FLINK

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #348
    
----
commit 5200ebf3586a0424093f160c287394c85f466d73
Author: Jean-Baptiste Onofré <jbonofre@apache.org>
Date:   2016-05-18T16:46:34Z

    [BEAM-286] Reorganize flink runner module to follow other runners structure

----


> Reorganize flink runner directories
> -----------------------------------
>
>                 Key: BEAM-286
>                 URL: https://issues.apache.org/jira/browse/BEAM-286
>             Project: Beam
>          Issue Type: Task
>          Components: runner-flink
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.1.0-incubating
>
>
> The flink runner Maven module uses two sub-modules: runner and examples. It's the only
one which use such layout (compare to spark, dataflow or inprocess/direct runners).
> I will propose a PR to align flink runner module with the other, keeping the examples
in a sub-directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message