beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-211) When using Create.of use it's #withCoder method instead of the created PCollection's #setCoder
Date Mon, 23 May 2016 23:45:13 GMT

    [ https://issues.apache.org/jira/browse/BEAM-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297355#comment-15297355
] 

ASF GitHub Bot commented on BEAM-211:
-------------------------------------

GitHub user ilganeli opened a pull request:

    https://github.com/apache/incubator-beam/pull/378

    [BEAM-211] Replace usages of PCollection.setCoder with Create.of().withCoder 

    * Replaced all usages of ```PCollection.setCoder`` with the recommended ```withCoder```.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilganeli/incubator-beam BEAM-211

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #378
    
----
commit 65519e1b37cdae00410ff99272b7782656de0c11
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2016-05-23T23:34:38Z

    Updated all existing instances of PCollection's #setCoder to use Create.of use it's #withCoder

commit 3a21f536cbcbe0bc6feef1a234e022d0bd29857b
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2016-05-23T23:43:44Z

    Fixed formatting changes.

commit 3a967e3add790a6acd4064f1b8ea63834107e482
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2016-05-23T23:44:45Z

    Deleted stale code.

----


> When using Create.of use it's #withCoder method instead of the created PCollection's
#setCoder
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-211
>                 URL: https://issues.apache.org/jira/browse/BEAM-211
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Priority: Minor
>
> See [~kenn] comment here:
> https://github.com/apache/incubator-beam/pull/179#discussion_r60171526



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message