Return-Path: X-Original-To: apmail-beam-commits-archive@minotaur.apache.org Delivered-To: apmail-beam-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECCDD19421 for ; Tue, 5 Apr 2016 22:14:19 +0000 (UTC) Received: (qmail 92297 invoked by uid 500); 5 Apr 2016 22:14:19 -0000 Delivered-To: apmail-beam-commits-archive@beam.apache.org Received: (qmail 92248 invoked by uid 500); 5 Apr 2016 22:14:19 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 92239 invoked by uid 99); 5 Apr 2016 22:14:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 22:14:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1A906C2648 for ; Tue, 5 Apr 2016 22:14:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.016 X-Spam-Level: X-Spam-Status: No, score=-5.016 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id CNd0Rg341A2j for ; Tue, 5 Apr 2016 22:14:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 238E45F19B for ; Tue, 5 Apr 2016 22:14:17 +0000 (UTC) Received: (qmail 92224 invoked by uid 99); 5 Apr 2016 22:14:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 22:14:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 36691DFB90; Tue, 5 Apr 2016 22:14:17 +0000 (UTC) From: tgroh To: commits@beam.incubator.apache.org Reply-To: commits@beam.incubator.apache.org Message-ID: Subject: [GitHub] incubator-beam pull request: [BEAM-22] Add PTransformOverride clas... Content-Type: text/plain Date: Tue, 5 Apr 2016 22:14:17 +0000 (UTC) GitHub user tgroh opened a pull request: https://github.com/apache/incubator-beam/pull/131 [BEAM-22] Add PTransformOverride class Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace "" in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- This provides the #shouldOverride method to determine if a PTransform override should be applied, based on the original PTransform. This permits overrides that are applied conditionally (such as shard-controlled writes). For all existing overrides, this value is equal to true. This is used in (written, but unpublished) overrides for TextIO.Write and AvroIO.Write, so the write can be overridden in terms of sharded writes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/incubator-beam ippr_ptransform_override_class Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #131 ---- commit 624ccb9359779161c2e5d6a79dc9b865aa22efb3 Author: Thomas Groh Date: 2016-03-29T17:03:25Z Add PTransformOverride class This provides the #shouldOverride method to determine if a PTransform override should be applied, based on the original PTransform. This permits overrides that are applied conditionally (such as shard-controlled writes). For all existing overrides, this value is equal to true. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---